Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix import path for SageMakerHook in airflow/contrib/sensors/sagemaker_training #20930

Merged
merged 2 commits into from
Jan 21, 2022

Conversation

josh-fell
Copy link
Contributor

@josh-fell josh-fell commented Jan 18, 2022

Related: #19891

Error being fixed:

airflow/contrib/sensors/sagemaker_training_sensor.py:22: error: Module "airflow.providers.amazon.aws.sensors.sagemaker_training" has no attribute "SageMakerHook"
    from airflow.providers.amazon.aws.sensors.sagemaker_training import (  # noqa
    ^

^ Add meaningful description above

Read the Pull Request Guidelines for more information.
In case of fundamental code change, Airflow Improvement Proposal (AIP) is needed.
In case of a new dependency, check compliance with the ASF 3rd Party License Policy.
In case of backwards incompatible changes please leave a note in UPDATING.md.

@josh-fell josh-fell changed the title Fix Mypy "no attribute" errors in airflow/contrib/sensors Fix import path for SageMakerHook in airflow/contrib/sensors/sagemaker_training Jan 20, 2022
@github-actions
Copy link

The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest main at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.

@github-actions github-actions bot added the full tests needed We need to run full set of tests for this PR to merge label Jan 20, 2022
@josh-fell josh-fell mentioned this pull request Jan 21, 2022
10 tasks
@potiuk potiuk merged commit 407606b into apache:main Jan 21, 2022
@josh-fell josh-fell deleted the mypy-fix-airflow-contrib-sensors branch January 21, 2022 17:26
@jedcunningham jedcunningham added the changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) label Mar 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:providers changelog:skip Changes that should be skipped from the changelog (CI, tests, etc..) full tests needed We need to run full set of tests for this PR to merge provider:microsoft-azure Azure-related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants